-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable motion sensors and background sync by default #2802
Conversation
Adding @bridiver to review, since this involves patching Taking a look myself, not sure how to avoid patching in a clean way (as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test plan works great! Change looks good to me. Let's wait until @bridiver can review before merging 😄
patches/components-content_settings-core-browser-content_settings_registry.cc.patch
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
cc: @fmarier per the feedback above (also needs a rebase) |
94de613
to
7d970c1
Compare
7d970c1
to
6d8b3fe
Compare
a12a1a3
to
540dec7
Compare
540dec7
to
f577340
Compare
Addressed in the latest revision.
f577340
to
06f1f35
Compare
Revert #2802 causing startup crashes
Fixes brave/brave-browser#4709 and brave/brave-browser#4789.
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
For background sync:
For either feature:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.